Simplify pure Python workflow into a single job #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pllim
approved these changes
Mar 10, 2022
Comment on lines
-62
to
-64
| - uses: actions/upload-artifact@v2 | ||
| with: | ||
| path: dist/* |
Member
There was a problem hiding this comment.
Would it be useful to keep the upload-artefact so people can download the wheel even if it isn't uploaded to PyPI? (Also, it should be easy to rebase #13 for this PR.)
Member
There was a problem hiding this comment.
Although happy to merge as I guess this is less important for pure python wheels.
Contributor
There was a problem hiding this comment.
People can always build their own wheel but why would they even need it?
Member
There was a problem hiding this comment.
That's right. Building locally to debug the wheels should be fine. Shall we merge this?
ConorMacBride
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned by @pllim in astropy/pytest-astropy-header#42 (comment), for the pure Python case we could just have a single job?