Skip to content

DEP: upgrade cibuildwheel to 4.0.0#393

Merged
Cadair merged 1 commit into
OpenAstronomy:mainfrom
neutrinoceros:dep/cibw4
Jun 8, 2026
Merged

DEP: upgrade cibuildwheel to 4.0.0#393
Cadair merged 1 commit into
OpenAstronomy:mainfrom
neutrinoceros:dep/cibw4

Conversation

@neutrinoceros
Copy link
Copy Markdown
Contributor

No description provided.

@neutrinoceros neutrinoceros changed the title DEP: upgrade cibuildwheel to 4.0.0(rc1) DEP: upgrade cibuildwheel to 4.0.0(rc2) Jun 5, 2026
@neutrinoceros neutrinoceros changed the title DEP: upgrade cibuildwheel to 4.0.0(rc2) DEP: upgrade cibuildwheel to 4.0.0 Jun 7, 2026
@neutrinoceros neutrinoceros marked this pull request as ready for review June 7, 2026 19:50
@neutrinoceros
Copy link
Copy Markdown
Contributor Author

I recommend upgrading other GHA dependencies as well and publishing every upgrade at once as a new major release.

@Cadair Cadair added this to the 3.0 milestone Jun 8, 2026
@Cadair
Copy link
Copy Markdown
Member

Cadair commented Jun 8, 2026

(This is a moot point as we are doing a major release for #397 anyway)

Why do you think this should be a major release of the workflows? Is there a breaking change in cibw 4?

@neutrinoceros
Copy link
Copy Markdown
Contributor Author

Several https://github.com/pypa/cibuildwheel/releases/tag/v4.0.0
Most notably, support for Python 3.8 and 3.13t is gone

@Cadair
Copy link
Copy Markdown
Member

Cadair commented Jun 8, 2026

I'm not sure if in general breaking changes in downstream actions should warrant major bumps for us, that would mean we do major bumps a lot. I think a clear changelog showing which actions get bumped should be enough.

@neutrinoceros
Copy link
Copy Markdown
Contributor Author

breaking changes in downstream actions

You mean "upstream" I think. I'm not arguing for every major change to translate as a major release here, but I do think that the ones that have user-visible impact should.

that would mean we do major bumps a lot.

Well, version numbers are cheap (virtually free), so I don't really get that argument.

@Cadair Cadair merged commit 8449fec into OpenAstronomy:main Jun 8, 2026
30 checks passed
@neutrinoceros neutrinoceros deleted the dep/cibw4 branch June 8, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants