Skip to content

fix: handle Windows IM attachment paths - #474

Merged
Gucc111 merged 1 commit into
OpenBMB:mainfrom
Gucc111:fix/windows-im-attachment-path
Aug 3, 2026
Merged

fix: handle Windows IM attachment paths#474
Gucc111 merged 1 commit into
OpenBMB:mainfrom
Gucc111:fix/windows-im-attachment-path

Conversation

@Gucc111

@Gucc111 Gucc111 commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Replace slash-based IM attachment path containment checks with a cross-platform path.relative guard.
  • Fix Windows runs incorrectly rejecting downloaded IM attachments as escaping their target directory.

Test plan

  • npm run build
  • node --test --test-force-exit --test-timeout 60000 "dist/tests/adapters/im-attachment-store.spec.js" (run before dropping the added test file per follow-up request)
  • node --test --test-force-exit --test-timeout 60000 "dist/tests/gateway/attachment-guidance.spec.js"
  • node --test --test-force-exit --test-timeout 60000 "dist/tests/adapters/feishu-permission-reply.spec.js"

Made with Cursor

Co-authored-by: Cursor <cursoragent@cursor.com>
@Gucc111
Gucc111 merged commit 8e2d66d into OpenBMB:main Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants