Skip to content

fix: css changes to edit button and username truncated#916

Merged
vnugent merged 4 commits into
OpenBeta:developfrom
SidV2:fix/long_username_truncated
Jul 14, 2023
Merged

fix: css changes to edit button and username truncated#916
vnugent merged 4 commits into
OpenBeta:developfrom
SidV2:fix/long_username_truncated

Conversation

@SidV2

@SidV2 SidV2 commented Jul 14, 2023

Copy link
Copy Markdown
Contributor

name: Pull request
about: Create a pull request
title: ''
labels: ''
assignees: ''


What type of PR is this?(check all applicable)

  • refactor
  • feature
  • bug fix
  • documentation
  • optimization
  • other

Description

Related Issues

Issue #911

What this PR achieves

This PR addresses the problem in user profile screen where a long username would flow out of the screen.

Screenshots, recordings

Notes

@vercel

vercel Bot commented Jul 14, 2023

Copy link
Copy Markdown

@SidV2 is attempting to deploy a commit to the openbeta-dev Team on Vercel.

A member of the Team first needs to authorize it.

@vercel

vercel Bot commented Jul 14, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
open-tacos ✅ Ready (Inspect) Visit Preview Jul 14, 2023 4:19pm

@SidV2 SidV2 temporarily deployed to Preview July 14, 2023 14:10 — with GitHub Actions Inactive
@vnugent

vnugent commented Jul 14, 2023

Copy link
Copy Markdown
Contributor

@SidV2 Thanks for this PR. I think you may have an old code base. Can you please fetch the latest develop branch and rebase?

@SidV2

SidV2 commented Jul 14, 2023

Copy link
Copy Markdown
Contributor Author

@SidV2 Thanks for this PR. I think you may have an old code base. Can you please fetch the latest develop branch and rebase?

Thank you. I have merged upstream develop into this branch now.

Comment thread src/components/users/PublicProfile.tsx Outdated
const ChangeUsernameLink = forOwnerOnly(() =>
<Link href='/account/changeUsername'><a className='text-sm link'>Edit</a></Link>)
<Link href='/account/changeUsername'>
<a className='text-sm inline-flex space-x-2 items-center whitespace-nowrap cursor-pointer disabled:cursor-auto disabled:opacity-50 border rounded-md border-gray-800 text-black drop-shadow-sm hover:ring-1 px-2 py-0.5'>Edit

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final request and we're good to merge. Now that the button is next to other buttons, can you change label to 'Edit profile' so that it's less confusing? Thank you.

Screenshot 2023-07-14 at 8 55 17 AM

@SidV2 SidV2 temporarily deployed to Preview July 14, 2023 16:18 — with GitHub Actions Inactive
@vnugent vnugent merged commit a988ff8 into OpenBeta:develop Jul 14, 2023
@vnugent

vnugent commented Jul 14, 2023

Copy link
Copy Markdown
Contributor

@all-contributors add @SidV2 for code

@allcontributors

Copy link
Copy Markdown
Contributor

@vnugent

I've put up a pull request to add @SidV2! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants