Feature mapping diagnostic - #544
Merged
Merged
Conversation
lohedges
temporarily deployed
to
biosimspace-build
August 1, 2026 17:13 — with
GitHub Actions
Inactive
lohedges
temporarily deployed
to
biosimspace-build
August 1, 2026 17:13 — with
GitHub Actions
Inactive
lohedges
temporarily deployed
to
biosimspace-build
August 1, 2026 17:13 — with
GitHub Actions
Inactive
lohedges
temporarily deployed
to
biosimspace-build
August 1, 2026 17:13 — with
GitHub Actions
Inactive
lohedges
temporarily deployed
to
biosimspace-build
August 1, 2026 17:13 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BioSimSpace.Align.matchAtomsnow tells users when it has probably returned a sub-optimal mapping. After computing the default MCS it looks for mapped atoms that have an unmapped heavy-atom neighbour of the same element on both molecules, i.e. attachment points where the search stopped symmetrically, which usually means a pairable atom was missed. If it finds any, it re-runs the MCS withringMatchesRingOnlyrelaxed and compares: only if the second mapping preserves every original pair and extends it sensibly (heavy to heavy, hydrogen to hydrogen) does it emit aUserWarningsuggestingmcs_kwargs={'ringMatchesRingOnly': False}. The check is purely observational, i.e. the originally computed mapping is always what gets returned, and it fires only where the advice can be acted on, so it is suppressed for internal callers such asrmsdAlign,flexAlign, the ROI path and ATM setup, which offer no way to pass MCS options through. The existing test set produces no false positives, but this is something that should be monitored over the current development cycle.develinto this branch before issuing this pull request (e.g. by runninggit pull origin devel): [y]