Bugfix/exclusive map access#117
Merged
Merged
Conversation
Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
…d DeleteInstanceInfo methods test: add concurrent access tests for instance information in MemStore Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
travisbcotton
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request improves concurrency safety in the in-memory CI store implementation by switching from read locks to write locks for all group and instance mutation methods. It also adds comprehensive tests to ensure thread safety under concurrent access scenarios.
Thread safety improvements:
MemStore(AddGroupData,UpdateGroupData,RemoveGroupData,SetInstanceInfo,DeleteInstanceInfo) to useLock/Unlockinstead ofRLock/RUnlockon their respective mutexes, ensuring exclusive access during writes and preventing data races. [1] [2] [3] [4] [5]Testing enhancements:
TestConcurrentInstanceAccessinciMemStore_test.goto verify correct behavior of the store under concurrent reads, writes, and mixed access patterns, helping to catch potential concurrency bugs.syncpackage to support goroutine synchronization in the new concurrency tests.Type of Change
For more info, see Contributing Guidelines.