-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[deps] Update dependency otplib to v13 #14013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4ba3317 to
a1f4df6
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
d0179d0 to
ebd891b
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #14013 +/- ##
==========================================
+ Coverage 31.10% 31.11% +0.01%
==========================================
Files 2921 2922 +1
Lines 193778 193791 +13
Branches 39559 39559
==========================================
+ Hits 60273 60297 +24
+ Misses 133505 133494 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ebd891b to
773b040
Compare
xfournet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested:
- support of code already generated by the previous version of lib -> need to override the minimal secret length to reduce it from 16 to 10 bytes
- regeneration of new code, test of the new code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the otplib dependency from v12.0.1 to v13.1.1, migrating the TOTP (Time-based One-Time Password) implementation to use the new v13 API. This major version update addresses multiple issues in the upstream library including crypto compatibility, bundle size, and API consistency.
Changes:
- Updates otplib from v12.0.1 to v13.1.1 with new dependencies (@noble/hashes, @scure/base)
- Creates a new totp utility module with guardrails to support backward compatibility with v12-generated secrets
- Migrates all OTP-related code from the v12 authenticator API to the v13 OTP class API
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| opencti-platform/opencti-graphql/package.json | Updates otplib dependency version from 12.0.1 to 13.1.1 |
| opencti-platform/opencti-graphql/yarn.lock | Updates lock file with new otplib packages and dependencies (@noble/hashes, @scure/base), removes thirty-two package |
| opencti-platform/opencti-graphql/src/utils/totp.ts | Creates new utility module exporting configured OTP instance with guardrails for v12 compatibility |
| opencti-platform/opencti-graphql/src/modules/auth/auth-domain.ts | Migrates from authenticator.check() to async totp.verify() in MFA verification |
| opencti-platform/opencti-graphql/src/domain/user.js | Migrates generateSecret(), keyuri(), and check() to v13 API across OTP generation, activation, and login functions |
773b040 to
7698d04
Compare
This PR contains the following updates:
12.0.1→13.1.1Release Notes
yeojz/otplib (otplib)
v13.1.1Compare Source
What's Changed
Full Changelog: yeojz/otplib@v13.1.0...v13.1.1
v13.1.0Compare Source
What's Changed
Full Changelog: yeojz/otplib@v13.0.2...v13.1.0
v13.0.2What's Changed
Full Changelog: yeojz/otplib@v13.0.0...v13.0.2
v13.0.0Compare Source
What's Changed
Full Changelog: yeojz/otplib@v12.0.1...v13.0.0
Related Issues
Configuration
📅 Schedule: Branch creation - At 12:00 AM through 04:59 AM and 10:00 PM through 11:59 PM, Monday through Friday ( * 0-4,22-23 * * 1-5 ), Only on Sunday and Saturday ( * * * * 0,6 ) in timezone Europe/Paris, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.