Skip to content

fix(streamer): harden Windows video transport and bounded recovery - #790

Merged
zortos293 merged 1 commit into
t3code/redesign-open-now-frameworkfrom
codex/fix-native-video-recovery
Sep 4, 2026
Merged

fix(streamer): harden Windows video transport and bounded recovery#790
zortos293 merged 1 commit into
t3code/redesign-open-now-frameworkfrom
codex/fix-native-video-recovery

Conversation

@zortos293

Copy link
Copy Markdown
Collaborator

Summary

  • Reserve exclusive Windows UDP sockets with bounded occupied-port fallback, and advertise the local address routed to the negotiated media peer.
  • Bound media recovery across duplicate terminal events and session claims; reset only on real video progress and keep the embedded video surface visible during recovery.
  • Report first-frame progress from the D3D11 path and persist transport/decode/control diagnostics, including zero-video-datagram and HTTP 503 failures.
  • Add regression coverage and affected-PC retest guidance; support a shorter native artifact path for Windows builds.

Verification

  • Native streamer workspace: 268 tests passed.
  • Complete Qt suite: 64 tests passed; includes fullscreen/F3 and overlay smoke coverage.
  • Full Windows build, packaged ZIP smoke test, and git diff --check passed.

Scope and remaining validation

The supplied trace received zero video UDP datagrams before decoding. These changes fix client transport/recovery defects, but playback on the affected Windows 11 / GTX 1650 PC still needs confirmation. External firewall/VPN/server failures, including HTTP 503, cannot be guaranteed resolved by a client patch.

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 28212339-f1cf-4112-a693-5ec207cc90b4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zortos293

Copy link
Copy Markdown
Collaborator Author

Pre-merge verification: reran the complete local Windows Qt suite; all 64 tests passed (18.06s). GitHub CI is not green: qt-ci linux-x64 fails cargo fmt --manifest-path native/opennow-core/Cargo.toml -- --check exclusively in gfn.rs, which is identical to the target branch. qt-ci macOS fails CMake configuration because the runner Qt install lacks Qt6GuiPrivate; the required find_package declaration is unchanged from the target branch. No required merge checks are configured. These existing CI issues are not resolved by this focused streamer patch; affected-PC playback remains unverified.

@zortos293
zortos293 merged commit 7e96a93 into t3code/redesign-open-now-framework Sep 4, 2026
8 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant