Bug: Search term should be cleared out of search bar when entering an org, user, or repo page

[jamlung-ri]

When I search for CIEL in global search and enter the repository, the term "ciel" continues to stay in the search bar, even though that search term is not being applied on the page. In any case where I search for an org, user, or repo and enter its page, I would think that the search term should be cleared out of the search bar.

@paulsonder @snyaggarwal Can you weigh in on this? Does my suggestion seem right?

Gif showing what I mean:

[snyaggarwal]

Well I am not sure what the correct answer is here. Youtube always keeps the search term, unless explicitly removed.
The search term is there but not applied. Can be confusing or useful. Need your help on this @paulsonder

[paulsonder]

This is a great catch and question. I don't have a clear answer, but do have some thoughts and questions...

• Persisting the search term reminds the user of their last query
• It gives them control to apply it again, with different search options offered in Searchlight to narrow or expand the relevancy.

You'll notice that the designs in Zeplin have actually been updated so that opening the search is via the icon in the navigation bar. This means that Searchlight opens, then closes once a User decides how they wish to proceed with their query.

That shifts the conversation to a question of whether that search term persists when Searchlight opens again... I think there's a lot of value in that, for the above described reasons but also to utilise Searchlight queries across different pages.

[snyaggarwal]

@jamlung-ri For now I have cleared the input if the route changes.

[jamlung-ri]

Awesome, this is working well now!