OpenConceptLab/ocl_issues#2599 | Performance improvements for Expansion concepts/mappings indexing - #888
Merged
Merged
Conversation
…on concepts/mappings indexing
paynejd
reviewed
Jul 2, 2026
paynejd
left a comment
paynejd
left a comment
Member
There was a problem hiding this comment.
The ~40x speedup is legitimate — partial field-append via Painless script vs. re-serializing the whole concept/mapping document. And the URL-derivation / partial-update approach matches the tasks in #2599. But I found two correctness regressions the benchmark and tests don't cover (both removal-related and value-equivalence), plus one edge note. Details inline.
…ference uri as well
paynejd
reviewed
Jul 2, 2026
paynejd
left a comment
paynejd
left a comment
Member
There was a problem hiding this comment.
One more minor efficiency note inline (the correctness item — HEAD collection_url — is in the thread above).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes OpenConceptLab/ocl_issues#2599
Summary