feat(#37): remove settings encryption + decrypt-then-migrate#67
Merged
Conversation
- Import settingsStore in ipc.ts; add SETTINGS_OPEN_FILE handler (shell.openPath) - Bridge config.openSettingsFile() in preload.ts - Type config.openSettingsFile in env.d.ts
- Remove hardcoded encryptionKey from electron-store (it was security theatre — the key was in the binary, providing no real protection) - Settings file is now plain JSON at userData/openconduit-settings.json, matching VS Code / Cursor convention - On first launch after upgrade, decryptLegacyStore() reads the old encrypted file using the old key, deletes it, then writes all settings to the new plain store — API keys and providers are preserved
…add routing to env.d.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #37 — client-side changes.
Changes
settings:open-fileIPCSETTINGS_OPEN_FILEhandler inipc.tsusingshell.openPath(settingsStore.path)preload.ts(config.openSettingsFile) and typed inenv.d.tsRemove settings encryption
encryptionKey: 'openconduit-v1'fromelectron-storeconfig — settings are now plain readable JSONdecryptLegacyStore()migration: on first launch after upgrade, detects the old binary-encrypted file, reads it with the legacy key, deletes it, and writes the decrypted data into the new plain JSON store