fix(scripts): remove undefined variable, fix os-release guard, move set -e, remove deprecated ::echo:: commands#15
Merged
Conversation
…et -e, remove deprecated ::echo:: commands - bundle.ps1: remove premature $BUNDLE_ID assignment using undefined $app_name (fixes #11) - install_build_deps: guard /etc/os-release source with file existence check (fixes #13) - install_cargo_bundle: move set -e to top of script so all failures are caught (fixes #14) - Grammatical fix in wasm/bundle comment (fixes #12) - Remove deprecated ::echo::on/off GitHub Actions commands from all bundle scripts and workflows (fixes #12)
This was referenced May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11, #12, #13, #14
Implements all four Copilot stub fixes (those PRs had only placeholder commits):
$app_namein bundle.ps1 #11script/windows/bundle.ps1: remove premature$BUNDLE_IDassignment that referenced undefined$app_name— the correct assignment already exists later in the script after$APP_NAMEis setscript/wasm/bundle: fix grammatical error in comment; remove deprecated::echo::on/offGitHub Actions commands from all bundle scripts and workflows (script/macos/bundle,script/linux/bundle,script/linux/bundle_appimage,script/wasm/bundle,script/windows/bundle.ps1,.github/workflows/cut_new_releases.yml,.github/actions/get_channel_config/action.yml)script/linux/install_build_deps: guardsource /etc/os-releasewith-f /etc/os-releasecheck to prevent silent failure on systems without that filescript/install_cargo_bundle: moveset -eto top of script so all command failures are caught, not just those inside the install branch