fix(conformance): advance protected matrix diagnostics - #137
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are cohesive, well-covered by targeted regression tests, and the updated lock/workflow pins are consistently propagated across tests and documentation.
Pull request overview
This PR advances the Phase 1 conformance “protected matrix” diagnostics by strengthening Git safe-directory handling for local worktree clones, adding schema-v2 evidence finalization error classification, and tightening validation of broker-owned Unix platform records using the frozen SDK validator contract.
Changes:
- Extend local schema-v2 checkout cloning to trust both the local worktree path and its resolved Git directory (
safe.directory=...), with regression coverage. - Introduce an async stage wrapper (
runSchemaV2StageAsync) to preserve bounded diagnostics for async schema-v2 evidence finalization failures, with test coverage. - Update the client-v1 conformance workflow to validate broker-owned Unix schema-v2 records via the frozen SDK contract parser, and refresh pinned harness/workflow authority hashes/docs.
File summaries
| File | Description |
|---|---|
| src/phase1-conformance.test.ts | Adds regression tests for dual safe.directory trust and async evidence finalization failure classification. |
| src/phase1-conformance-lock.test.ts | Updates expected harness/workflow authority pins to match refreshed lock. |
| src/client-v1-conformance-workflow.test.ts | Extends workflow-content assertions to cover frozen contract parsing of broker-owned records. |
| scripts/phase1-schema-v2-producer.mjs | Adds async stage wrapper, extends protected local clone config with both safe.directory entries, and wraps evidence finalization to emit bounded diagnostics. |
| phase1-conformance.lock.json | Refreshes pinned harness authority revision/tree and affected file digests. |
| docs/phase1-conformance.md | Updates documented byte counts and SHA-256 values for pinned workflow/script artifacts. |
| .github/workflows/client-v1-conformance.yml | Validates broker-owned Unix platform record via frozen SDK contract parser; updates pinned artifact metadata. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
corepack pnpm@10.34.0 --ignore-workspace testcorepack pnpm@10.34.0 --ignore-workspace lintcorepack pnpm@10.34.0 --ignore-workspace typecheckcorepack pnpm@10.34.0 --ignore-workspace buildAdvances OpenCoven/sdk#38.