Fix protected conformance bootstraps - #58
Merged
Merged
Conversation
Avoid FileInfo.Parent under strict PowerShell and defer the Unix Tauri CLI check until frozen dependencies are installed inside the producer boundary. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Bind the protected conformance lock and documentation to the durable bootstrap fix commit and its exact workflow bytes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes Phase 1 protected conformance bootstraps by hardening Windows ancestor traversal under strict PowerShell, deferring the Unix Tauri CLI version check until after the frozen dependency install inside the isolated producer, and repinning the conformance lock/harness authority to the updated, reviewed workflow bytes.
Changes:
- Update Windows PowerShell ancestor traversal to route
FileInfothrough.Directorybefore.Parenttraversal (avoidsFileInfo.Parentunder strict mode). - Move the Unix
tauriversion verification to occur afterpnpm install --frozen-lockfile --ignore-scripts(and add workflow/spec tests to enforce the ordering). - Repin harness authority (revision/tree) and workflow byte SHA-256 in the conformance lock and corresponding tests/docs.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/phase1-conformance-lock.test.ts |
Updates expected harness revision/tree assertions for the repinned harness authority. |
src/client-v1-conformance-workflow.test.ts |
Adds regression tests asserting (1) Unix Tauri check is deferred until after install and (2) Windows bootstrap avoids FileInfo.Parent. |
phase1-conformance.lock.json |
Repins harness authority revision/tree and updates the workflow blob/SHA-256 to the new reviewed bytes. |
docs/phase1-conformance.md |
Updates the documented byte count and SHA-256 for the reviewed workflow file. |
.github/workflows/client-v1-conformance.yml |
Fixes strict PowerShell traversal of file ancestors and removes the premature Unix tauri check from the early toolchain gate. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
BunsDev
added a commit
that referenced
this pull request
Sep 1, 2026
Rebased onto main after the protected bootstrap fix (#58) landed, so the previous repin pinned a commit that no longer exists on this branch. Repins harness and harnessAuthority to b49cebc, the rebased fix commit, and refreshes the two blobs that commit changes: client-v1-conformance.yml and windows-job-supervisor.cs. Verified: the pinned tree equals `git rev-parse b49cebc^{tree}` and every one of the 25 harnessAuthority blobs resolves to its locked value at that revision. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FileInfo.Directorybefore directory-parent traversal under strict PowerShellFailure evidence
33474082852: Windows failed withThe property Parent cannot be found on this objectpnpm exec tauri --versionran before dependencies existedValidation