Fix protected conformance runtime isolation - #94
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
It modifies security-sensitive isolation and toolchain trust-boundary behavior across scripts and CI workflow, which warrants final human validation of the threat model and runner/runtime assumptions.
Pull request overview
This PR tightens the Phase 1 conformance “protected runtime” isolation model by moving Windows path hardening into the restricted child bootstrap, eliminating shared-object Git clones for root-owned checkouts, and ensuring the Unix supervised boundary uses broker-resolved, root-copied toolchain executables (Node/pnpm/rustup) rather than relying on ambient paths or Corepack.
Changes:
- Route Phase 1 harness operations through a copied
pnpmexecutable and remove explicitcorepackinvocation paths. - Harden Unix authority cloning by using
safe.directory=<sourceRoot>plusgit clone --local --no-hardlinks(no alternates/shared objects). - Update workflow/tests/docs/lock metadata to reflect the new isolation mechanics and repinned harness authority.
File summaries
| File | Description |
|---|---|
| src/specification-guards.test.ts | Updates expectations for harness invoking pnpm directly rather than corepack pnpm@.... |
| src/phase1-conformance.test.ts | Adds assertions around non-shared Git clone behavior and adjusts toolchain observation to use a PATH-resolved pnpm. |
| src/phase1-conformance-lock.test.ts | Repins expected harness authority revision/tree and associated file digests. |
| src/client-v1-conformance-workflow.test.ts | Updates workflow assertions for resolved tool executables and pnpm usage without Corepack. |
| scripts/unix-producer-supervisor.test.sh | Extends supervisor fixture to pass explicit Node/pnpm/rustup executables into the supervised boundary. |
| scripts/unix-producer-supervisor.sh | Requires and copies broker-resolved Node/pnpm/rustup into a root-owned trusted directory; PATH is rooted through that trust boundary. |
| scripts/unix-producer-command.sh | Switches frozen Unix install/build steps from corepack pnpm ... to pnpm ... under the supervised boundary. |
| scripts/phase1-conformance.mjs | Uses pnpm directly, hardens local clone semantics with safe.directory + --local --no-hardlinks, and updates packaging/observation commands accordingly. |
| phase1-conformance.lock.json | Updates the pinned harness revision and file digests to match the repinned authority state. |
| docs/phase1-conformance.md | Documents the revised isolation model (copied executables, local clone constraints) and updates byte/digest tables. |
| .github/workflows/client-v1-conformance.yml | Embeds the Windows no-reparse guard into the restricted child bootstrap and passes resolved Node/pnpm/rustup paths into the Unix supervisor. |
Review details
- Files reviewed: 11/11 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation