Skip to content

[codex] Add memory lifecycle controls#142

Closed
CompleteDotTech wants to merge 3 commits into
OpenCoven:mainfrom
CompleteDotTech:codex/issue-109-memory-controls
Closed

[codex] Add memory lifecycle controls#142
CompleteDotTech wants to merge 3 commits into
OpenCoven:mainfrom
CompleteDotTech:codex/issue-109-memory-controls

Conversation

@CompleteDotTech

@CompleteDotTech CompleteDotTech commented Jul 7, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds a coven-code memory named command for metadata-only listing, local/team delete, local/team redaction, team conflict inspection, conflict resolution, and explicitly scoped hosted namespace deletion.
  • Uses existing memory/tombstone/conflict/scope helpers so lifecycle operations validate keys, reject malformed destructive arguments, avoid traversal, preserve audit metadata, and never print original memory bodies.
  • Documents operator workflows for local, team, and hosted memory lifecycle controls.

Context

  • Related issue/user request: Fixes Add memory retention, deletion, and redaction controls #109
  • Scope: focused command surface, tests, and configuration docs for memory retention/deletion/redaction/conflict operations.
  • Non-goals: server API changes, broad memory sync refactors, or changing existing memory storage formats beyond existing delete/redact helpers.

Changes

  • Registers the memory named command in src-rust/crates/commands/src/named_commands.rs.
  • Adds safe subcommands: list, delete, redact, conflicts, resolve-conflict, and hosted-delete.
  • Fails closed on unknown flags, duplicate flags, missing flag values, and extra positional arguments for mutating memory operations.
  • Requires --team for keys under the reserved team/ directory so local and team-memory targeting cannot be confused.
  • Adds coverage for no-body output, tombstones, redaction stubs, traversal rejection, malformed argument rejection, local/team targeting, conflict listing/resolution, and hosted scope isolation.
  • Adds docs/configuration.md lifecycle operation examples and hosted delete scope requirements.

Validation

Record exact commands and outcomes. Mark items N/A with a reason when they do not apply.

  • git diff --check - passed; Git emitted line-ending normalization warnings for touched files only.
  • cargo fmt --all - passed.
  • cargo check --workspace - passed.
  • cargo clippy --workspace --all-targets -- -D warnings - passed.
  • cargo test --workspace - passed.
  • Targeted/manual checks: cargo test --package claurst-commands named_commands::tests::test_memory - 17 passed.
  • Review loop: repeated maintainer-style code review after each fix; final post-validation review found zero code/docs findings.
  • GitHub Actions: Format, lint, and test passed on c5d89b2; Interactive terminal suite passed on c5d89b2.
  • Not run: N/A.

PR Readiness

  • Diff is limited to the intended files.
  • Generated files were not edited by hand.
  • User-facing docs/help were updated or are not needed.
  • No secrets, credentials, local paths, or unrelated logs are included.
  • Remaining risks or follow-up work are listed above.

Note: Vercel reports "Authorization required to deploy" for this fork PR. The repo GitHub Actions code checks are passing.

Signed-off-by: Timothy Wayne Gregg <Timothy.Gregg@complete.tech>
@vercel

vercel Bot commented Jul 7, 2026

Copy link
Copy Markdown

@romgenie is attempting to deploy a commit to the 0xBuns Team on Vercel.

A member of the Team first needs to authorize it.

Fixes OpenCoven#109

Signed-off-by: Timothy Wayne Gregg <Timothy.Gregg@complete.tech>
@CompleteDotTech
CompleteDotTech marked this pull request as ready for review July 7, 2026 17:43
Fixes OpenCoven#109

Signed-off-by: Timothy Wayne Gregg <Timothy.Gregg@complete.tech>
@BunsDev

BunsDev commented Jul 8, 2026

Copy link
Copy Markdown
Member

Thanks @romgenie. Issue #109 landed via #144 with a CLI operator surface (coven-code memory list/expire/redact/delete/ledger plus retention classes), which superseded most of this PR. The team-conflict operations were the piece #144 lacked — they are re-landed on that surface in #145 (coven-code memory conflicts / resolve-conflict) with your Co-authored-by credit preserved. Closing as superseded.

Uberration pushed a commit to Uberration/meatycoven-code that referenced this pull request Jul 18, 2026
OpenCoven#145)

Ports the team-memory conflict inspection and resolution operations from
PR OpenCoven#142 onto the coven-code memory operator surface that landed in OpenCoven#144:

- coven-code memory conflicts [--dir <team-memory-path>] [--json] lists
  unresolved pull conflicts (key, kind, reason)
- coven-code memory resolve-conflict <key> [--dir <path>] removes the
  persisted conflict record after validating the key against traversal

closes OpenCoven#142

Co-authored-by: romgenie <5861166+romgenie@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add memory retention, deletion, and redaction controls

2 participants