Skip to content

[PATCH v2] travis: doxygen 1.8.13#181

Closed
muvarov wants to merge 3 commits intoOpenDataPlane:masterfrom
muvarov:master2
Closed

[PATCH v2] travis: doxygen 1.8.13#181
muvarov wants to merge 3 commits intoOpenDataPlane:masterfrom
muvarov:master2

Conversation

@muvarov
Copy link
Copy Markdown
Contributor

@muvarov muvarov commented Sep 19, 2017

Update doxygen to 1.8.13

After we fix warnings we can threat warnings as errors. That option is available only in later doxygen releases.

Signed-off-by: Maxim Uvarov maxim.uvarov@linaro.org

Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>
@muvarov muvarov changed the title travis: doxygen 1.8.13 [PATCH v1] travis: doxygen 1.8.13 Sep 19, 2017
@lumag
Copy link
Copy Markdown

lumag commented Sep 19, 2017

Could you please add it to cache?

@muvarov
Copy link
Copy Markdown
Contributor Author

muvarov commented Sep 19, 2017

@lumag to add it to cache we need to install doxygen to some directory and add to odp config option to specify where is doxygen. Cache will save about 1 minute of execution. Probably there is some m4 macros already exist to point to installed doxygen directory.

Copy link
Copy Markdown
Contributor

@Bill-Fischofer-Linaro Bill-Fischofer-Linaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I concur with @lumag suggestion to add this to the cache, but otherwise this looks reasonable, so consider this a review of v2 :)

@muvarov
Copy link
Copy Markdown
Contributor Author

muvarov commented Sep 19, 2017

@lumag @Bill-Fischofer-Linaro doxygen m4 macros does not have option to specify directory of where is it installed. I will try to play with it, maybe simple path will be enough.

declare more clear syntax to capture doxygen warnings.

Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>
Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>
@muvarov muvarov changed the title [PATCH v1] travis: doxygen 1.8.13 [PATCH v2] travis: doxygen 1.8.13 Sep 20, 2017
@lumag
Copy link
Copy Markdown

lumag commented Sep 20, 2017

Looks good now, thank you!
Reviewed-by: Dmitry Eremin-Solenikov dmitry.ereminsolenikov@linaro.org

@muvarov
Copy link
Copy Markdown
Contributor Author

muvarov commented Sep 21, 2017

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants