[PATCH v1] Fix AES-GCM tag check#23
Closed
lumag wants to merge 2 commits intoOpenDataPlane:masterfrom
Closed
Conversation
added 2 commits
May 5, 2017 04:13
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>
Currently odp_crypto code will happily accept wrong tags, because the check for EVP_DecryptFinal_ex return code is incorrect. This function returns 0 if tag is incorrect, not < 0. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>
Author
|
@Bill-Fischofer-Linaro ping |
Bill-Fischofer-Linaro
approved these changes
May 17, 2017
Contributor
Bill-Fischofer-Linaro
left a comment
Bill-Fischofer-Linaro
left a comment
There was a problem hiding this comment.
Reviewed-and-tested-by: Bill Fischofer bill.fischofer@linaro.org
Author
|
@muvarov could you please merge this PR? |
Contributor
|
Merged. |
Author
|
@muvarov It had to be merged into master branch, not api-next! Master branch still contains this vulnerability. BTW: why are you merging PRs by manually applying paches, rather than merging the original branch into it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.