[PATCH v1] linux-generic: crypto: don't leak sessions if creation fails#25
Closed
lumag wants to merge 1 commit intoOpenDataPlane:masterfrom
Closed
[PATCH v1] linux-generic: crypto: don't leak sessions if creation fails#25lumag wants to merge 1 commit intoOpenDataPlane:masterfrom
lumag wants to merge 1 commit intoOpenDataPlane:masterfrom
Conversation
We should free allocated session in odp_crypto_session_create() error paths, so that the session is not leaked. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>
muvarov
changed the title
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
==========================================
- Coverage 78.32% 78.28% -0.05%
==========================================
Files 172 172
Lines 31462 31468 +6
==========================================
- Hits 24644 24634 -10
- Misses 6818 6834 +16
Continue to review full report at Codecov.
|
Bill-Fischofer-Linaro
approved these changes
May 10, 2017
Contributor
Bill-Fischofer-Linaro
left a comment
Bill-Fischofer-Linaro
left a comment
There was a problem hiding this comment.
Looks good. Review by acclamation.
Contributor
|
Meged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should free allocated session in odp_crypto_session_create() error
paths, so that the session is not leaked.
Signed-off-by: Dmitry Eremin-Solenikov dmitry.ereminsolenikov@linaro.org