type-c-service: Thread UCSI port commands to hardware#498
Merged
asasine merged 7 commits intoOpenDevicePartnership:mainfrom Sep 24, 2025
Merged
type-c-service: Thread UCSI port commands to hardware#498asasine merged 7 commits intoOpenDevicePartnership:mainfrom
asasine merged 7 commits intoOpenDevicePartnership:mainfrom
Conversation
432fb84 to
5a80f95
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements threading of UCSI (USB Type-C Connector System Software Interface) port commands to the hardware controller, enabling proper command routing and response handling for UCSI operations.
- Adds support for executing UCSI commands through the controller interface
- Updates the UCSI service to route commands to hardware instead of returning mock responses
- Implements command execution in both TPS6699x driver and mock controller
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| type-c-service/src/wrapper/pd.rs | Adds debug logging and UCSI command handling in port command processing |
| type-c-service/src/service/ucsi.rs | Refactors LPM command processing to route to hardware with config override support |
| type-c-service/src/service/config.rs | Adds optional UCSI port capabilities configuration field |
| type-c-service/src/driver/tps6699x.rs | Implements UCSI command execution for TPS6699x hardware driver |
| examples/std/src/lib/type_c/mock_controller.rs | Adds UCSI command execution to mock controller for testing |
| embedded-service/src/type_c/controller.rs | Defines UCSI command/response types and controller trait method |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jerrysxie
previously approved these changes
Sep 15, 2025
5a80f95 to
930389d
Compare
930389d to
5141b44
Compare
Contributor
Author
|
Depends on OpenDevicePartnership/tps6699x#75 |
asasine
previously approved these changes
Sep 23, 2025
added 4 commits
September 24, 2025 09:48
asasine
approved these changes
Sep 24, 2025
gjpmsft
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change due to the new trait function.
Depends on: