Skip to content

type-c-service: Thread UCSI port commands to hardware#498

Merged
asasine merged 7 commits intoOpenDevicePartnership:mainfrom
RobertZ2011:ucsi-hardware
Sep 24, 2025
Merged

type-c-service: Thread UCSI port commands to hardware#498
asasine merged 7 commits intoOpenDevicePartnership:mainfrom
RobertZ2011:ucsi-hardware

Conversation

@RobertZ2011
Copy link
Copy Markdown
Contributor

@RobertZ2011 RobertZ2011 commented Sep 15, 2025

@RobertZ2011 RobertZ2011 self-assigned this Sep 15, 2025
@RobertZ2011 RobertZ2011 marked this pull request as ready for review September 15, 2025 19:22
@RobertZ2011 RobertZ2011 requested a review from a team as a code owner September 15, 2025 19:22
Copilot AI review requested due to automatic review settings September 15, 2025 19:22
@RobertZ2011 RobertZ2011 requested a review from a team as a code owner September 15, 2025 19:22
@RobertZ2011 RobertZ2011 added the BREAKING CHANGE Marks breaking changes label Sep 15, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements threading of UCSI (USB Type-C Connector System Software Interface) port commands to the hardware controller, enabling proper command routing and response handling for UCSI operations.

  • Adds support for executing UCSI commands through the controller interface
  • Updates the UCSI service to route commands to hardware instead of returning mock responses
  • Implements command execution in both TPS6699x driver and mock controller

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
type-c-service/src/wrapper/pd.rs Adds debug logging and UCSI command handling in port command processing
type-c-service/src/service/ucsi.rs Refactors LPM command processing to route to hardware with config override support
type-c-service/src/service/config.rs Adds optional UCSI port capabilities configuration field
type-c-service/src/driver/tps6699x.rs Implements UCSI command execution for TPS6699x hardware driver
examples/std/src/lib/type_c/mock_controller.rs Adds UCSI command execution to mock controller for testing
embedded-service/src/type_c/controller.rs Defines UCSI command/response types and controller trait method

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread type-c-service/src/wrapper/pd.rs Outdated
Comment thread type-c-service/src/service/ucsi.rs Outdated
jerrysxie
jerrysxie previously approved these changes Sep 15, 2025
@RobertZ2011
Copy link
Copy Markdown
Contributor Author

Depends on OpenDevicePartnership/tps6699x#75

@RobertZ2011 RobertZ2011 marked this pull request as ready for review September 23, 2025 22:17
asasine
asasine previously approved these changes Sep 23, 2025
@asasine asasine merged commit 9963be3 into OpenDevicePartnership:main Sep 24, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in ODP Backlog Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BREAKING CHANGE Marks breaking changes

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants