ucsi/lpm: Add iterator over GET_PDOS content#51
Merged
RobertZ2011 merged 2 commits intoOpenDevicePartnership:mainfrom Sep 24, 2025
Merged
ucsi/lpm: Add iterator over GET_PDOS content#51RobertZ2011 merged 2 commits intoOpenDevicePartnership:mainfrom
RobertZ2011 merged 2 commits intoOpenDevicePartnership:mainfrom
Conversation
* Also fix PDO count * Add PDO length constant
RobertZ2011
force-pushed
the
get-pdos-iterator
branch
from
3cce997 to
067fbb6
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds an iterator interface to the GET_PDOS response data and fixes the PDO count calculation to comply with the UCSI specification. The changes improve the API ergonomics by providing safe iteration over PDO data while ensuring correct specification compliance.
- Fixed PDO count calculation by adding/subtracting 1 to match UCSI spec requirements
- Added iterator methods (
iter,iter_mut,len,is_empty) to ResponseData for convenient PDO traversal - Added PDO_LEN constant for better code maintainability
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/ucsi/lpm/get_pdos.rs | Fixed PDO count calculation, added iterator interface to ResponseData, and updated error handling |
| src/pdo/mod.rs | Added PDO_LEN constant for standardized PDO size definition |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
RobertZ2011
requested review from
felipebalbi,
jerrysxie,
kurtjd and
tullom
asasine
previously approved these changes
Sep 23, 2025
tullom
previously approved these changes
Sep 23, 2025
asasine
approved these changes
Sep 24, 2025
Merged
2 tasks
asasine
pushed a commit
to OpenDevicePartnership/embedded-services
that referenced
this pull request
Sep 24, 2025
Breaking change due to the new trait function. Depends on: - [x] OpenDevicePartnership/embedded-usb-pd#51 - [x] OpenDevicePartnership/tps6699x#75 --------- Co-authored-by: Adam Sasine <adam.sasine@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking due to making
rawprivate, iterators can be used to access contents now.