Skip to content

.github: Update Patina QEMU PR Val for patina-qemu Changes #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
makubacki merged 1 commit into from
Mar 27, 2026
Merged

.github: Update Patina QEMU PR Val for patina-qemu Changes #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .github/actions/run-patina-qemu-validation/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,6 @@ inputs:
description: Shut down QEMU after running ('true' or 'false').
required: false
default: 'false'
toolchain:
description: Rust toolchain tag.
required: true

runs:
using: composite
Expand All @@ -62,7 +59,6 @@ runs:
PRE_COMPILED_ROM: ${{ inputs.pre-compiled-rom }}
QEMU_PATH: ${{ inputs.qemu-path }}
SHUTDOWN_AFTER_RUN: ${{ inputs.shutdown-after-run }}
TOOLCHAIN: ${{ inputs.toolchain }}
run: |
import json, os, subprocess, sys

Expand All @@ -77,7 +73,6 @@ runs:
"pre_compiled_rom": os.environ["PRE_COMPILED_ROM"],
"qemu_path": os.environ.get("QEMU_PATH", ""),
"shutdown_after_run": os.environ.get("SHUTDOWN_AFTER_RUN", "false").lower() == "true",
"toolchain": os.environ["TOOLCHAIN"],
})

script = os.path.join(os.environ["ACTION_PATH"], "run_qemu_validation.py")
Expand Down
3 changes: 0 additions & 3 deletions .github/actions/run-patina-qemu-validation/run_qemu_validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@
needed on Windows when QEMU is not on PATH. Default: "".
shutdown_after_run (bool, optional) Shut down QEMU after running.
Default: false.
toolchain (string, required) Rust toolchain tag (e.g. "GCC5" or
"VS2022").
"""

import argparse
Expand Down Expand Up @@ -188,7 +186,6 @@ def main() -> int:
"--patina-dxe-core-repo", config["patina_dxe_core_repo"],
"--platform", config["platform"],
"--pre-compiled-rom", config["pre_compiled_rom"],
"--toolchain", config["toolchain"],
]

if config.get("qemu_path"):
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/PatinaQemuPrValidation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,7 +574,6 @@ jobs:
platform: ${{ matrix.platform }}
pre-compiled-rom: ${{ env.FW_DIR }}/${{ matrix.rom_subpath }}
shutdown-after-run: 'true'
toolchain: ${{ needs.vars.outputs['linux-toolchain'] }}

- name: Upload QEMU Linux ${{ matrix.platform }} Logs
if: always()
Expand Down Expand Up @@ -754,7 +753,6 @@ jobs:
pre-compiled-rom: ${{ env.FW_DIR }}/Q35/DEBUG-VS2022/QEMUQ35_CODE.fd
qemu-path: ${{ steps.qemu-path.outputs.qemu_exec }}
shutdown-after-run: 'true'
toolchain: ${{ needs.vars.outputs['windows-toolchain'] }}

- name: Upload QEMU Windows Logs
if: always()
Expand Down