Fix some issues with key-value loops#2363
Merged
wixoaGit merged 3 commits intoOpenDreamProject:masterfrom Aug 15, 2025
Merged
Conversation
boring-cyborg
bot
added
Compiler
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2360
Fix #2361
Creating a list enumerator now copies that list's associated values, if it has any. The EnumerateNoAssign opcode also no longer uses a DreamReference to grab the list, removing the need for an LValue.
Potentially room for optimization here, as always copying the associated values regardless of loop type is a bit much. Trying to get goonstation compiling again though.