Fix for(var/V in list) for special lists#2368
Merged
wixoaGit merged 1 commit intoOpenDreamProject:masterfrom Aug 21, 2025
Merged
Fix for(var/V in list) for special lists#2368wixoaGit merged 1 commit intoOpenDreamProject:masterfrom
for(var/V in list) for special lists#2368wixoaGit merged 1 commit intoOpenDreamProject:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2363 broke list enumeration on special lists because it started enumerating on
DreamList's internal_valuesarray which special lists don't use.I moved every
GetValues()implementation toEnumerateValues()instead, as a step towards making every list implement IDreamList instead of inheriting DreamList.