Remove OpenMVS subdirectory from superbuild - #2025
Merged
Merged
Conversation
Fixes OpenMVS binaries being unable to find their dependencies when MSIX packaged When MSIX packaged, the PATH environment variable is not used for DLL lookup, so OpenMVS wouldn't find Boost, CDAL and etc. DLLs By removing the subdirectory, the exe lives at the same places as the DLL dependencies, fixing the issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes OpenMVS binaries being unable to find their dependencies when MSIX packaged
When MSIX packaged, the PATH environment variable is not used for DLL lookup, so OpenMVS wouldn't find Boost, CDAL and etc. DLLs
By removing the subdirectory, the exe lives at the same places as the DLL dependencies, fixing the issue