Feature/controller evcs analog heatingelement reference target - #3919
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3919 +/- ##
=============================================
+ Coverage 55.71% 55.71% +0.01%
+ Complexity 19118 19113 -5
=============================================
Files 3674 3674
Lines 172019 172011 -8
Branches 14178 14175 -3
=============================================
+ Hits 95817 95823 +6
+ Misses 72409 72395 -14
Partials 3793 3793 🚀 New features to boost your workflow:
|
sfeilmeier
approved these changes
Aug 26, 2026
sfeilmeier
left a comment
Contributor
There was a problem hiding this comment.
Thank you for proceeding. I am awaiting the moment when we can remove updateReferenceFilter() 🚀 (not sure if this will actually be possible, though)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates three controllers from
OpenemsComponent.updateReferenceFilter()to the Reference Target Plugin (@GenerateTargetsFromReferences).This continues the same migration as the ESS controller PRs. The plugin resolves
${config.*_id}into the OSGi reference target before@Activate, so the runtime filter rewrite is no longer needed.Bundles
1.
Controller.Evcs@GenerateTargetsFromReferences("evcs")STATIC/GREEDY/MANDATORYwithtarget = "(&(id=${config.evcs_id})(enabled=true))"evcs_target()fromConfig/MyConfigConfigurationAdmin(cm) — still used to rewrite force-/default-charge power when hardware limits are exceededDummyConfigurationAdminkept becausecmis still used2.
Controller.IO.Analog@GenerateTargetsFromReferences("analogOutput")STATIC/GREEDY/MANDATORYwithtarget = "(&(id=${config.analogOutput_id})(enabled=true))"analogOutput_target()fromConfig/MyConfigcm— it was only used forupdateReferenceFiltertimedatareference unchangedDummyConfigurationAdminremoved3.
Controller.IO.HeatingElement@GenerateTargetsFromReferences("meter")Controller.IO.HeatPump.SgReady):cardinality = OPTIONAL,policyOption = GREEDY,target = "(&(id=${config.meter_id})(enabled=true))"(not
STATIC, becausemeter_iddefaults to"")(false=true)/updateReferenceFilterRawhandlingmeter_target()fromConfig/MyConfigcm— it was only used for the meter filterDummyConfigurationAdminwiring only (left on JUnit 4 to keep the diff small)