Conversation
jh-RLI
approved these changes
Oct 16, 2024
Contributor
jh-RLI
left a comment
There was a problem hiding this comment.
That's good. I think it's worth taking a second look. We should probably also add some regex for validation. Once we have implemented this in the Oemetabuilder, we can use the schema to validate the form inputs and provide feedback to the user about exactly which fields have not been filled in correctly. The format (type) is good regex, for example, would ensure that users use the format “topic.table_name” for the field “tables name” instead of “table name”.
However, this can happen in another PR and would not be a breaking change
Member
Author
|
Thanks for the detailed review. I agree that there can be more "pattern" fields in the schema. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the discussion
The JSON schema spec allows some build in additional types.
Used options are:
Type of change (CHANGELOG.md)
Added
Workflow checklist
Automation
Closes #146
PR-Assignee
Reviewer