Skip to content

Add explicit json types #146 #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jh-RLI merged 6 commits into from
Oct 16, 2024
Merged

Add explicit json types #146 #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
875071b
Add format #146
Ludee Oct 15, 2024
a43b7dd
Add format #146
Ludee Oct 15, 2024
213f390
Add format #146
Ludee Oct 15, 2024
0233559
Add format #146
Ludee Oct 15, 2024
e93b24d
Add format #146
Ludee Oct 15, 2024
77af095
Update changelog #146
Ludee Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ Here is a template for new release sections

- Add key nullable to fields section (columns) [(#161)](https://github.com/OpenEnergyPlatform/oemetadata/pull/161)

- Add explicit json types [(#166)](https://github.com/OpenEnergyPlatform/oemetadata/pull/166)

### Changed

- Remove comment field as it holds information on how to fill out the metadata and therefore should not be part of the actual oemetadata but the documentation. [#???](https://github.com/OpenEnergyPlatform/oemetadata/pull/)
Expand Down
6 changes: 4 additions & 2 deletions metadata/v200_draft/build_source/schemas/general.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,8 @@
"null"
],
"badge": "Bronze",
"title": "Embargo Period Start"
"title": "Embargo Period Start",
"format": "date"
},
"end": {
"description": "The end date of the embargo period. This is the intended publication date.",
Expand All @@ -145,7 +146,8 @@
"null"
],
"badge": "Bronze",
"title": "Embargo Period End (Publication Date)"
"title": "Embargo Period End (Publication Date)",
"format": "date"
},
"isActive": {
"description": "A boolean key that indicates if the embargo period is currently active. Must be changed to False on the embargo period end date.",
Expand Down
1 change: 1 addition & 0 deletions metadata/v200_draft/build_source/schemas/general_collection.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
],
"badge": "Silver",
"title": "Collection identifier",
"format": "uri",
"readonly": true
}
},
Expand Down
5 changes: 3 additions & 2 deletions metadata/v200_draft/build_source/schemas/licences.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@
"null"
],
"badge": "Bronze",
"title": "Path"
"title": "Path",
"format": "uri"
},
"instruction": {
"description": "A short description of rights and restrictions. The use of tl;drLegal is recommended.",
Expand All @@ -51,7 +52,7 @@
"title": "Instruction"
},
"attribution": {
"description": "The copyrightholder of the data set. If attribution licenses are used, that name must be acknowledged.",
"description": "The copyright holder of the data set. If attribution licenses are used, that name must be acknowledged.",
"example": "© Reiner Lemoine Institut",
"type": [
"string",
Expand Down
7 changes: 4 additions & 3 deletions metadata/v200_draft/build_source/schemas/meta.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"null"
],
"badge": null,
"title": "Metadata version"
"title": "Metadata Version"
},
"metadataLicense": {
"description": "Object describing the license of the provided metadata.",
Expand Down Expand Up @@ -49,11 +49,12 @@
"null"
],
"badge": null,
"title": "Path"
"title": "Path",
"format": "uri"
}
},
"badge": null,
"title": "Metadata license"
"title": "Metadata License"
}
},
"title": "Meta Metadata",
Expand Down
9 changes: 5 additions & 4 deletions metadata/v200_draft/build_source/schemas/provenance.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,17 +61,18 @@
"title": "Roles"
},
"date": {
"description": "Date of the contribution. If the contribution took more than a day, use the date of the final contribiution. Date Format is ISO 8601.",
"description": "The date of the final contribution. Date Format is ISO 8601.",
"example": "2016-06-16",
"type": [
"string",
"null"
],
"badge": null,
"title": "Date"
"title": "Date",
"format": "date"
},
"object": {
"description": "Target of contribution. Which part of the package was supplied/changed.",
"description": "Target of contribution. Which part of the package was supplied or changed.",
"example": "data and metadata",
"type": [
"string",
Expand All @@ -82,7 +83,7 @@
},
"comment": {
"description": "Free text comment on what has been done.",
"example": "Fix typo in the title.",
"example": "Add general context.",
"type": [
"string",
"null"
Expand Down