Skip to content

When changing adaptors, default to the newest specific version#3042

Closed
taylordowns2000 wants to merge 1 commit intomainfrom
hotfix-2843
Closed

When changing adaptors, default to the newest specific version#3042
taylordowns2000 wants to merge 1 commit intomainfrom
hotfix-2843

Conversation

@taylordowns2000
Copy link
Copy Markdown
Member

@taylordowns2000 taylordowns2000 commented Mar 20, 2025

Description

This is a hotfix for #2843. It's not a deep fix, and you'll note that when creating a new workflow you still start with language-common@latest but frankly I think that's just fine—we don't do breaking changes to common very often.

I don't want to spend much time on this if we're all in agreement that the way to go is SEMVER (see #2844) and not getting the normal behavior to be "the most recent specific version" is already costing us lots of time.

Also note that it appears we tried to fix this before: https://github.com/OpenFn/lightning/blob/main/lib/lightning_web/live/workflow_live/edit.ex#L2374C1-L2387C6

Validation steps

  1. Create a new step in a workflow.
  2. See that it defaults of language-common@latest.
  3. Pick an adaptor.
  4. See that it changes to the latest SPECIFIC version for that adaptor.

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our Responsible AI Policy

Pre-submission checklist

  • I have performed a self-review of my code.
  • I have implemented and tested all related authorization policies. (e.g., :owner, :admin, :editor, :viewer)
  • I have updated the changelog.
  • I have ticked a box in "AI usage" in this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.68%. Comparing base (8cf9452) to head (5f8bb37).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
lib/lightning_web/live/job_live/adaptor_picker.ex 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3042      +/-   ##
==========================================
- Coverage   91.69%   91.68%   -0.02%     
==========================================
  Files         349      349              
  Lines       12975    12980       +5     
==========================================
+ Hits        11898    11901       +3     
- Misses       1077     1079       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@josephjclark josephjclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not looked at the implementation but the behaviour in the app is great

I agree that the common default is fine

@taylordowns2000
Copy link
Copy Markdown
Member Author

I've not looked at the implementation but the behaviour in the app is great

I agree that the common default is fine

Great. I think is very short lived code. We are both redoing in react and changing the behavior to SEMVER soon. I say ship it. @stuartc ?

@theroinaochieng theroinaochieng moved this from New Issues to In review in Core Mar 26, 2025
@stuartc stuartc mentioned this pull request Mar 27, 2025
11 tasks
@stuartc
Copy link
Copy Markdown
Member

stuartc commented Mar 27, 2025

Superseded by #3069

@stuartc stuartc closed this Mar 27, 2025
@github-project-automation github-project-automation bot moved this from In review to Done in Core Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants