When changing adaptors, default to the newest specific version#3042
Closed
taylordowns2000 wants to merge 1 commit intomainfrom
Closed
When changing adaptors, default to the newest specific version#3042taylordowns2000 wants to merge 1 commit intomainfrom
taylordowns2000 wants to merge 1 commit intomainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3042 +/- ##
==========================================
- Coverage 91.69% 91.68% -0.02%
==========================================
Files 349 349
Lines 12975 12980 +5
==========================================
+ Hits 11898 11901 +3
- Misses 1077 1079 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
josephjclark
approved these changes
Mar 22, 2025
Collaborator
josephjclark
left a comment
There was a problem hiding this comment.
I've not looked at the implementation but the behaviour in the app is great
I agree that the common default is fine
Member
Author
Great. I think is very short lived code. We are both redoing in react and changing the behavior to SEMVER soon. I say ship it. @stuartc ? |
Member
|
Superseded by #3069 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a hotfix for #2843. It's not a deep fix, and you'll note that when creating a new workflow you still start with
language-common@latestbut frankly I think that's just fine—we don't do breaking changes to common very often.I don't want to spend much time on this if we're all in agreement that the way to go is SEMVER (see #2844) and not getting the normal behavior to be "the most recent specific version" is already costing us lots of time.
Also note that it appears we tried to fix this before: https://github.com/OpenFn/lightning/blob/main/lib/lightning_web/live/workflow_live/edit.ex#L2374C1-L2387C6
Validation steps
language-common@latest.AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy
Pre-submission checklist
:owner,:admin,:editor,:viewer)