Conversation
When selecting a new adaptor, default to using the latest specific version number instead of @latest. The @latest option remains available but requires explicit opt-in and displays a warning pill about potential breaking changes. Closes #2843 - Removed unused import of PetalComponents.Badge in lightning_web.ex. - Changed attr type from :string to :any for class in icons.ex. - Added color attr to pill component with color attribute. - Adjusted form component styles for better responsiveness in form.ex. - Improved layout and tooltip handling in adaptor_picker.ex, including version selection logic and UI updates.
- Introduced unit tests for the `get_adaptor_version_options/1` function in the AdaptorPicker module. - Verified that the function returns sorted version options and handles specific versions correctly. - Ensured proper formatting and ordering of version outputs. This addition enhances test coverage for adaptor selection functionality.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3069 +/- ##
==========================================
- Coverage 91.22% 91.19% -0.03%
==========================================
Files 356 356
Lines 13119 13135 +16
==========================================
+ Hits 11968 11979 +11
- Misses 1151 1156 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
taylordowns2000
approved these changes
Mar 27, 2025
Member
taylordowns2000
left a comment
taylordowns2000
left a comment
There was a problem hiding this comment.
it's gorgeous. thank you. huge improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When selecting a new adaptor, default to using the latest specific version number
instead of
@latest. The@latestoption remains available but requires explicitopt-in and displays a warning pill about potential breaking changes.
Closes #2843
Additional notes for the reviewer
This does not change the default adaptor version when creating a new job or workflow, that is controlled by the workflow store/front end right now - so is arguably out of scope for now.
However as mentioned above, when changing the adaptor itself in the form; the latest version is selected (but not
@latest).This supercedes #3042.
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy
Pre-submission checklist
:owner,:admin,:editor,:viewer)