Reply cleanly on unhandled credential errors in run channel#4881
Merged
Conversation
RunChannel.handle_credential_error/5 pattern-matched a fixed set of error tags with no fallback, so an unexpected error term — most notably an OAuth provider timeout during token refresh, which surfaces as an untyped transport error — raised FunctionClauseError and crashed the channel mid-fetch:credential, dropping the worker's connection. Add a fallback clause that logs the unexpected term and replies with a clean error so the worker receives a response instead of losing the connection.
42430fd to
4ba2628
Compare
Security Review ✅
|
Collaborator
Author
|
@elias-ba I'm merging this in. I know you were interested in some metrics? I haven't added any, this change simply stops the run channel from crashing when it receives an unknown error from the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
RunChannel.handle_credential_error/5 pattern-matched a fixed set of error tags with no fallback, so an unexpected error term — most notably an OAuth provider timeout during token refresh, which surfaces as an untyped transport error — raised FunctionClauseError and crashed the channel mid-fetch:credential, dropping the worker's connection.
Add a fallback clause that logs the unexpected term and replies with a clean error so the worker receives a response instead of losing the connection.
Closes #4853
Validation steps
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy
Pre-submission checklist
/reviewwith Claude Code)
(e.g.,
:owner,:admin,:editor,:viewer)