Replace vulnerable Phoenix version#4957
Merged
Merged
Conversation
b7fb4be to
9fcfc9f
Compare
Security Review ✅
|
midigofrank
approved these changes
Jul 9, 2026
midigofrank
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @rorymckinley
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates a vulnerable version of Phoenix. I have deployed this to staging and clicked around and i also ran the SAAS tests when running on this version of Lightning.
One note of caution: Phoenix now sets a limit of 100 concurrent channels per connection - this will cause issues if the number of concurrent runs per worker exceeds 100. While that situation is hard for me to imagine :) it is worth checking if we have ever encountered this in an actual implementation?
Closes #4956
Validation steps
I am not sure - other than the tests, once could run this branch locally and check general behaviour?
Additional notes for the reviewer
The forerunner of the automated telephone exchange was invented in 1891 by an undertaker in Missouri named Almon Strowger. He apparently developed it after discovering that a local telephone exchange operator was directing all potential customer to his competition.
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy
Pre-submission checklist
/reviewwith Claude Code)
(e.g.,
:owner,:admin,:editor,:viewer)