Update cookbooks for v1.7 #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
jthorton
reviewed
Oct 21, 2025
| "metadata": { | ||
| "slideshow": { | ||
| "slide_type": "" | ||
| }, |
There was a problem hiding this comment.
Not a fan of the new dict repr {'unit': 'kelvin', 'val': 298.15} compared to the old <Quantity(298.15, 'kelvin')> but thats just a personal pref.
Reply via ReviewNB
jthorton
approved these changes
Oct 21, 2025
atravitz
force-pushed
the
v1.7_cookbooks
branch
from
13cb8ef to
0cb8217
Compare
atravitz
added a commit
that referenced
this pull request
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main discussion point here is that I had to drop the
to_rfe_alchemical_networkportion of thecreate_alchemical_networksnotebook.This was necessary because the latter cannot adapt settings.