Conversation
This reverts commit 24c2b8d.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #696 +/- ##
==========================================
+ Coverage 98.76% 98.79% +0.03%
==========================================
Files 40 40
Lines 2508 2491 -17
==========================================
- Hits 2477 2461 -16
+ Misses 31 30 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
note: codecov is only failing because of reduced lines of executed code |
mikemhenry
reviewed
Jan 13, 2026
mikemhenry
approved these changes
Jan 13, 2026
Contributor
mikemhenry
left a comment
mikemhenry
left a comment
There was a problem hiding this comment.
LGTM -- really just one question RE: do we want to exclude vendor code from out linters/formatters
Contributor
Author
|
excluded vendors, I think that's a good idea. thanks @mikemhenry ! |
|
No API break detected ✅ |
atravitz
added a commit
that referenced
this pull request
Mar 2, 2026
* drop abc inheritance from ComponentMapping * remove unused imports in tests * update pyproject.toml * remove more unused imports * remove more unused imports * add comments * Revert "drop abc inheritance from ComponentMapping" This reverts commit 24c2b8d. * fixing a few imports * add ignores to vendored code * remove no-op * omit vendored code from formatting * omit vendored code from formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tips
Since this will create a commit, it is best to make this comment when you are finished with your work.
Checklist
newsentryDevelopers certificate of origin