feat: exorcist worker #1833
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feat/warehouse #1833 +/- ##
==================================================
- Coverage 90.33% 90.13% -0.20%
==================================================
Files 212 220 +8
Lines 20086 20849 +763
==================================================
+ Hits 18144 18793 +649
- Misses 1942 2056 +114
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Seems I still have some unit testing to finish up, but this should be enough to highlight the use case for interested partners. |
946a9be to
8d4a139
Compare
|
A few notes on how to run this code: We need to first generate a To run a single task you use something like this: openfe worker warehouseThis will only run a task to completion and then stop. To run this in a loop, you can do something like this: https://gist.github.com/ethanholz/775027b469d6038f3dc958110c635c4c |
|
@atravitz I think we need to discuss this at some point soon. My understanding was that warehouse & exorcist was going to be decoupled from planning? |
The exorcist implementation is built to accept units as discussed. To demonstrate capabilities, I have added a flag to warehouse so that you can test and validate some of the functionality today. |
Signed-off-by: Ethan Holz <ethan.holz@omsf.io>
| return None | ||
| db, taskid, unit = task | ||
| # 2. Construct the context | ||
| # NOTE: On changes to context, this can easily be replaced with external storage objects |
There was a problem hiding this comment.
| # NOTE: On changes to context, this can easily be replaced with external storage objects | |
| # NOTE: On changes to context (gufe PR #753), this can easily be replaced with external storage objects |
Adds support for a Filesystem-backed
exorcistworker that can runProtocolUnitsfrom anAlchemicalNetwork. Adding @atravitz and @IAlibay for reference.Note that this is an implementation that does not require the changes to contexts in OpenFreeEnergy/gufe#753, to keep these features independent, but the expectation is that whenever we merge gufe #753, we should then update the relevant code here to take advantage of that introduced flexibility.
Also note that this PR took some commits from #1824, but circumvents changes to
execute_DAG.Checklist
newsentry, or the changes are not user-facing.pre-commit.ci autofix.Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).
Developers certificate of origin