Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1972 +/- ##
=======================================
Coverage 94.97% 94.97%
=======================================
Files 216 216
Lines 20480 20481 +1
=======================================
+ Hits 19451 19452 +1
Misses 1029 1029
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
No API break detected ✅ |
dwhswenson
approved these changes
Apr 30, 2026
Member
dwhswenson
left a comment
There was a problem hiding this comment.
Confirmed locally that this speeds up CLI! Thanks!
Pretty much the changes I expected, too. I note that CodeCov complaints are because the download_only option isn't tested, which seems to be an existing miss, not a new regression (just that some imports got moved in there).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as raised by @dwhswenson - calling the command line is taking ~5s as of v1.11. This PR rearranges some imports so that we're back to aroudn ~0.4 seconds.
Checklist
newsentry, or the changes are not user-facing.pre-commit.ci autofix.Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).
Developers certificate of origin