Skip to content

Raise an error for empty HybridTopology atom mappings - #2120

Merged
jthorton merged 4 commits into
mainfrom
htop_mapping_val
Aug 4, 2026
Merged

Raise an error for empty HybridTopology atom mappings#2120
jthorton merged 4 commits into
mainfrom
htop_mapping_val

Conversation

@jthorton

@jthorton jthorton commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

The protocol currently allows atom mappings to be empty, resulting in an uninformative indexing error in validation, this PR adds validation specifically for this case.

LLM / AI generated code disclosure

LLMs or other AI-powered tools (beyond simple IDE use cases) were used in this contribution: yes / no
If yes, please provide details here: No

Checklist

  • All new code is appropriately documented (user-facing code must have complete docstrings).
  • Added a news entry, or the changes are not user-facing.
  • Ran pre-commit: you can run pre-commit locally or comment on this PR with pre-commit.ci autofix.
  • Filled in the AI generated code disclosure.

Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).

Developers certificate of origin

@jthorton

jthorton commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator Author

pre-commit.ci autofix

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

No API break detected ✅

View workflow run

Griffe output
$ griffe check "openfe" -s src --no-inspection --no-color --verbose -a origin/main

$ griffe check "openfecli" -s src --no-inspection --no-color --verbose -a origin/main

@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.46%. Comparing base (1692562) to head (577f9fc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2120      +/-   ##
==========================================
- Coverage   95.13%   90.46%   -4.67%     
==========================================
  Files         213      213              
  Lines       20871    20878       +7     
==========================================
- Hits        19855    18887     -968     
- Misses       1016     1991     +975     
Flag Coverage Δ
fast-tests 90.46% <100.00%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jthorton
jthorton merged commit c68e34b into main Aug 4, 2026
10 checks passed
@jthorton
jthorton deleted the htop_mapping_val branch August 4, 2026 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants