Track wallet after Scaffold generation #33#34
Merged
Conversation
layko-andrey
reviewed
Mar 9, 2021
| @field:NotBlank @field:Digits(integer = Int.MAX_VALUE, fraction = Int.MAX_VALUE) var fiatAmount: String? = null, | ||
| @field:NotNull var currency: Currency? = null, | ||
| @field:NotBlank @field:Digits(integer = Int.MAX_VALUE, fraction = Int.MAX_VALUE) var conversionAmount: String? = null, | ||
| var webHook: String? = null, |
Contributor
There was a problem hiding this comment.
Webhook url mandatory parameter in Open State
Member
Author
There was a problem hiding this comment.
Yes, but we send onyl if it has webhhook. Or should it be also mandatory in Open API?
Contributor
There was a problem hiding this comment.
Yes, it should be mandatory. Request to Open State would fail if no webhook url would be specified
| @@ -80,6 +83,7 @@ class DefaultEthereumScaffoldService( | |||
| val properties = request.properties.map { propertyRepository.save(EthereumScaffoldProperty.of(scaffold, it)) } | |||
| scaffold.property.addAll(properties) | |||
| getScaffoldSummary(scaffold.address, openKey.user, true) | |||
Contributor
There was a problem hiding this comment.
Webhook is mandatory parameter in Open State
layko-andrey
approved these changes
Mar 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Track wallet after Scaffold generation #33