Provide curve metadata when curve needs no market data - #2788
Open
vedjaw wants to merge 1 commit into
Open
Conversation
RatesCurveInputs.builder().build() left curveMetadata null, which fails validation when a CurveDefinition has no nodes (or nodes with empty requirements). Build empty inputs with DefaultCurveMetadata of the curve name. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RatesCurveGroupMarketDataFunction.curveInputsusedRatesCurveInputs.builder().build()for curve definitions that do not require market data. That leftcurveMetadatanull and failed validation with “Argument 'curveMetadata' must not be null”.RatesCurveInputs.of(ImmutableMap.of(), DefaultCurveMetadata.of(curveDefn.getName()))instead.Test plan
RatesCurveGroupMarketDataFunctionTest.curveDefinitionWithoutMarketDataNodesFixes #2743
Made with Cursor