Added java implementation of coprime numbers.#2478
Open
skydans wants to merge 1 commit intoOpenGenus:masterfrom
Open
Added java implementation of coprime numbers.#2478skydans wants to merge 1 commit intoOpenGenus:masterfrom
skydans wants to merge 1 commit intoOpenGenus:masterfrom
Conversation
arnavb
approved these changes
Oct 25, 2017
Member
arnavb
left a comment
arnavb
left a comment
There was a problem hiding this comment.
Don't forget to read the Java Style Guide!
| @@ -0,0 +1,15 @@ | |||
| class CoprimeNumbers{ | |||
| public static long gcd(long c,long d){ | |||
| if(d==0){ | |||
Member
There was a problem hiding this comment.
Ternary operator could be used here:
return (d == 0) ? c : gcd(d,c%d);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue: #807
Changes:
Added java implementation of coprime numbers.