Conversation
|
It is not encouraged to delete files. Kindly make the changes and it will be good to be merged 👍 |
|
@AdiChat The problem is that the original author has not mentioned any licence, so by default we may consider it as copyright protected. As Jeff Atwood says,
So this program would be incompatible with the license of cosmos, GNU GPLv3. So I'd rather delete a few plagiarised codes than using other people's code illegally. |
| int i; | ||
| pNode->value = 0; | ||
|
|
||
There was a problem hiding this comment.
Is whitespace on blank lines like this actually wanted?
There was a problem hiding this comment.
@polyzen I don't know what the standards are in such cases, but my editor(Kate) adds whitespaces in blank lines when aligning the code. I couldn't find anything about it on the Internet.
There was a problem hiding this comment.
It's subjective, not objective, but trailing whitespace is more often frowned upon than not. Even more frowned upon when a patch clobbers history of lines like this for no reason other than whitespace changes.
| bool isPresent(struct Node *head, int data); | ||
|
|
||
| bool | ||
| isPresent(struct Node *head, int data); |
There was a problem hiding this comment.
I'm not convinced that putting types on separate lines like this in function prototypes is normal. I have mostly seen prototypes as single lines, with function definitions having the type on the line above.
There was a problem hiding this comment.
Thanks! fixed!
| free(p); \ | ||
| p = NULL; | ||
|
|
There was a problem hiding this comment.
The indentation here was probably intentional, since the statements are part of the FREE macro. I don't see what removing the indent adds.
There was a problem hiding this comment.
Thanks for noting that. I'll fix it.
|
@AdiChat The removed code is just a copy-paste of the original, without any credit. I think that even though there were credits, it's not a good practice to provide a copy-paste of a third person code. We can take inspiration from a code found in the Internet, and mention the author, but copy and paste it gives a bad image. |
Fixes issue:
Some code fixes in C programs
Changes:
Fixed errors and warning in some programs. Deleted a program which was plagiarised.