palindrome_in_singly_linked_list.c by iashreya · Pull Request #3344 · OpenGenus/cosmos

iashreya · 2018-03-01T15:38:49Z

Fixes issue:

Changes:

arnavb

https://github.com/OpenGenus/cosmos/blob/master/guides/coding_style/c/README.md <--- Please follow our C Style Guide.

iashreya · 2018-03-03T05:56:47Z

code/data_structures/src/list/singly_linked_list/operations/PalindromeInASinglyLinkedList.c

@@ -0,0 +1,58 @@
+#include<stdio.h>
+#include<stdlib.h>


I've made some changes, have a look.

arnavb · 2018-03-02T13:17:55Z

code/data_structures/src/list/singly_linked_list/operations/PalindromeInASinglyLinkedList.c

@@ -0,0 +1,58 @@
+#include<stdio.h>
+#include<stdlib.h>
+int count = 0,  flag = 1, *f = &flag;


Avoid globals. Move variables to main and pass them around.

arnavb · 2018-03-02T13:18:03Z

code/data_structures/src/list/singly_linked_list/operations/PalindromeInASinglyLinkedList.c

+
+  struct node
+    {
+        int  info;


Fix indentation.

arnavb · 2018-03-02T13:18:10Z

code/data_structures/src/list/singly_linked_list/operations/PalindromeInASinglyLinkedList.c

+    {
+        int  info;
+        struct node  *link;
+    }*start = NULL, *ptr1 ;


Avoid globals.

arnavb · 2018-03-02T13:18:17Z

code/data_structures/src/list/singly_linked_list/operations/PalindromeInASinglyLinkedList.c

+        struct  node*temp, *ptr;
+
+        while(proceed == 1)
+    {    temp = (struct node *)malloc(sizeof(struct node));


Indentation.

arnavb · 2018-03-02T13:18:28Z

code/data_structures/src/list/singly_linked_list/operations/PalindromeInASinglyLinkedList.c

+        ptr1 = ptr1->link;
+    }
+
+void main()


int. Also all types go on their own line according to our style guide.

arnavb · 2018-03-02T13:18:38Z

code/data_structures/src/list/singly_linked_list/operations/PalindromeInASinglyLinkedList.c

+    create();
+    check(start);
+    if(flag == 1)
+        puts("PALINDROME");


Use printf.

iashreya · 2018-03-03T05:56:47Z

code/data_structures/src/list/singly_linked_list/operations/PalindromeInASinglyLinkedList.c

@@ -0,0 +1,58 @@
+#include<stdio.h>
+#include<stdlib.h>


I've made some changes, have a look.

arnavb · 2018-03-03T13:45:02Z

code/data_structures/src/list/singly_linked_list/operations/PalindromeInASinglyLinkedList.c

+struct node
+{
+    int  info;
+    struct node  *link;


Inconsistency with *. Should be struct node* link, unless the style guide says otherwise.

arnavb · 2018-03-03T13:45:18Z

code/data_structures/src/list/singly_linked_list/operations/PalindromeInASinglyLinkedList.c

+
+//Function for creating the linked list
+struct node* create(struct node *start)
+{   int proceed = 1;


Statements should not be on same line as braces.

arnavb · 2018-03-03T13:46:19Z

code/data_structures/src/list/singly_linked_list/operations/PalindromeInASinglyLinkedList.c

+};
+
+//Function for creating the linked list
+struct node* create(struct node *start)


Type goes on its own line.

arnavb · 2018-03-03T13:46:31Z

code/data_structures/src/list/singly_linked_list/operations/PalindromeInASinglyLinkedList.c

+        temp->link = NULL;
+        puts("Enter info") ;
+        scanf("%d", &temp->info);
+       if(start == NULL)


Indentation fix here and below.

arnavb · 2018-03-03T13:46:44Z

code/data_structures/src/list/singly_linked_list/operations/PalindromeInASinglyLinkedList.c

+    return(ptr_fwd->link);
+}
+
+void main()


int main. void should be the parameters.

arnavb · 2018-03-07T13:50:10Z

code/data_structures/src/list/singly_linked_list/operations/PalindromeInASinglyLinkedList.c

+struct node
+{
+    int  info;
+    struct node*  link;


Remove 1 space from before link.

arnavb · 2018-03-07T13:50:26Z

code/data_structures/src/list/singly_linked_list/operations/PalindromeInASinglyLinkedList.c

+
+//Function for creating the linked list
+
+    struct node* create(struct node*  start)


Remove indent.
Move struct node* to its own line.

arnavb · 2018-03-07T13:50:53Z

code/data_structures/src/list/singly_linked_list/operations/PalindromeInASinglyLinkedList.c

+        temp = (struct node *)malloc(sizeof(struct node));
+        temp->link = NULL;
+        puts("Enter info") ;
+        scanf("%d", &temp->info);


I repeat myself; Please fix the indentation.

I do not understand what you are asking for. Please elaborate!

@iashreya Looks like you have fixed it now. Good job!

arnavb · 2018-03-07T13:51:05Z

code/data_structures/src/list/singly_linked_list/operations/PalindromeInASinglyLinkedList.c

+}
+
+//Function to check if the list forms a palindrome or not
+struct node* check(struct node *ptr_bck, struct node *ptr_fwd, int *f)


Type on its own line.

arnavb · 2018-03-07T13:51:23Z

code/data_structures/src/list/singly_linked_list/operations/PalindromeInASinglyLinkedList.c

+}
+
+int main(void)
+{   struct node *start = NULL;


Move this down a line.

arnavb · 2018-03-07T13:51:30Z

code/data_structures/src/list/singly_linked_list/operations/PalindromeInASinglyLinkedList.c

+    return(ptr_fwd->link);
+}
+
+int main(void)


Move the type to its own line.

arnavb · 2018-03-07T16:10:12Z

code/data_structures/src/list/singly_linked_list/operations/PalindromeInASinglyLinkedList.c

+        temp = (struct node *)malloc(sizeof(struct node));
+        temp->link = NULL;
+        puts("Enter info") ;
+        scanf("%d", &temp->info);


@iashreya Looks like you have fixed it now. Good job!

arnavb · 2018-03-07T16:10:33Z

code/data_structures/src/list/singly_linked_list/operations/PalindromeInASinglyLinkedList.c

+    struct node* link;
+};
+//Function for creating the linked list
+struct node* create(struct node*  start) 


The type goes on its own line for all functions. Eg:

struct node* create(struct node* start)

arnavb · 2018-03-07T16:10:51Z

code/data_structures/src/list/singly_linked_list/operations/PalindromeInASinglyLinkedList.c

@@ -0,0 +1,62 @@
+#include<stdio.h>


The filename should be all lowercase + separated by underscores.

By filename, do you mean "PalindromeInSinglyLinkedList.c" ?

@iashreya Yes.

arnavb · 2018-03-07T16:11:06Z

code/data_structures/src/list/singly_linked_list/operations/PalindromeInASinglyLinkedList.c

+    return(start);
+}
+//Function to check if the list forms a palindrome or not
+struct node* check(struct node *ptr_bck, struct node *ptr_fwd, int *f)


arnavb · 2018-03-07T16:11:11Z

code/data_structures/src/list/singly_linked_list/operations/PalindromeInASinglyLinkedList.c

+    return(ptr_fwd->link);
+}
+
+int main(void)


Here as well.

PalindromeInSinglyLinkedList.c

b33b8db

arnavb requested changes Mar 2, 2018

View reviewed changes

Update PalindromeInASinglyLinkedList.c

dbfc32e

iashreya commented Mar 3, 2018

View reviewed changes

arnavb requested changes Mar 3, 2018

View reviewed changes

Update PalindromeInASinglyLinkedList.c

b0291fb

arnavb requested changes Mar 7, 2018

View reviewed changes

Update PalindromeInASinglyLinkedList.c

1b0cee0

arnavb requested changes Mar 7, 2018

View reviewed changes

Update PalindromeInASinglyLinkedList.c

7994e1f

iashreya changed the title ~~PalindromeInSinglyLinkedList.c~~ palindrome_in_singly_linked_list.c Mar 8, 2018


		//Function for creating the linked list

		struct node* create(struct node* start)

		@@ -0,0 +1,58 @@
		#include<stdio.h>
		#include<stdlib.h>

		@@ -0,0 +1,58 @@
		#include<stdio.h>
		#include<stdlib.h>

Conversation

iashreya commented Mar 1, 2018

Uh oh!

arnavb left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iashreya Mar 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

iashreya Mar 7, 2018 •

edited

Loading