add_polynomials.c : added a function for tidy up the heap.#3501
Open
christianbender wants to merge 3 commits intoOpenGenus:masterfrom
Open
add_polynomials.c : added a function for tidy up the heap.#3501christianbender wants to merge 3 commits intoOpenGenus:masterfrom
christianbender wants to merge 3 commits intoOpenGenus:masterfrom
Conversation
arnavb
requested changes
Apr 19, 2018
| */ | ||
| void | ||
| create_node(int x, int y, struct Node **temp) | ||
| void create_node(int x, int y, struct Node **temp) |
Member
There was a problem hiding this comment.
The older version was correct; The C style guide says the type goes on its own line.
|
|
||
| void free_poly(struct Node * poly) | ||
| { | ||
| struct Node* tmp; |
Member
There was a problem hiding this comment.
* should be attached to variable, not type.
| { | ||
| struct Node* tmp; | ||
| while(poly) | ||
| { |
| void free_poly(struct Node * poly) | ||
| { | ||
| struct Node* tmp; | ||
| while(poly) |
| struct Node* tmp; | ||
| while(poly) | ||
| { | ||
| tmp = NULL; |
Member
There was a problem hiding this comment.
I would just move the declaration in here to limit the variable scope.
| free_poly(poly1); | ||
| free_poly(poly2); | ||
|
|
||
| return 0; |
Member
There was a problem hiding this comment.
Keep the parentheses. C style guide.
Author
|
@arnavb Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
free_poly(...)for tidy up the heap.