baconian.java : fixed syntax error and improved code #3548
Open
christianbender wants to merge 2 commits intoOpenGenus:masterfrom
Open
baconian.java : fixed syntax error and improved code #3548christianbender wants to merge 2 commits intoOpenGenus:masterfrom
christianbender wants to merge 2 commits intoOpenGenus:masterfrom
Conversation
arnavb
requested changes
May 10, 2018
|
|
||
| public String encode(String word) { | ||
| StringBuilder results = new StringBuilder(); | ||
| String results = ""; |
Member
There was a problem hiding this comment.
I feel like the assignment isn't necessary.
Author
There was a problem hiding this comment.
@arnavb In Java variables must be initalized otherwise the compiler complains
| word = word.toLowerCase(); | ||
| for (int start = 0; start < word.length() / 5; ++start) { | ||
| StringBuilder code = new StringBuilder(); | ||
| String code = ""; |
| public static void main(String [] args) { | ||
| Baconian bac = new Baconian(); | ||
| System.out.println(bac.encode("Wikipedia")); | ||
| System.out.println(bac.decode("babbaabaaaababaabaaaabbbbaabaaaaabbabaaaaaaaa")); |
Member
There was a problem hiding this comment.
Add comment for expected outputs.
Author
|
@arnavb Changed the code as requested |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue:
Changes:
mainmethod for testing.getKeyFromValue(...)encode(...)decode(...)StringBuilderand usedStringinstead.