Ruby: Add code for average stream numbers#3932
Open
mayanktap wants to merge 1 commit intoOpenGenus:masterfrom
Open
Ruby: Add code for average stream numbers#3932mayanktap wants to merge 1 commit intoOpenGenus:masterfrom
mayanktap wants to merge 1 commit intoOpenGenus:masterfrom
Conversation
4 tasks
Author
|
Hi @AdiChat Let me know in case of any discrepancy. |
arnavb
reviewed
Mar 19, 2019
| puts avg | ||
| resultant_array << avg | ||
| end | ||
| resultant_array |
Member
There was a problem hiding this comment.
What purpose does the return serve? Also, instead of printing out the average, why not yield to a block each new computed average instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue:
This PR implements the average stream number algorithm in Ruby. The issue corresponding to this PR is: #3931
Changes:
File added:
cosmos/code/mathematical_algorithms/src/average_stream_numbers/average_stream_numbers.rb