Skip to content

fix #4002 : ported python2 strassen to python3 and added test case#4012

Open
yedhink wants to merge 1 commit intoOpenGenus:masterfrom
yedhink:4002-port-to-python3
Open

fix #4002 : ported python2 strassen to python3 and added test case#4012
yedhink wants to merge 1 commit intoOpenGenus:masterfrom
yedhink:4002-port-to-python3

Conversation

@yedhink
Copy link
Contributor

@yedhink yedhink commented Mar 29, 2019

Fixes issue:
fix #4002

Changes:
removed previous python2 implementation of strassens multiplication and added the python3 code for the same. Also added a test case of a 4x4 matrix for testing the code.

Running Test Case
python3 strassen.py < test_case_4x4_matrix

@arnavb
Copy link
Member

arnavb commented Mar 31, 2019

@yedhink This issue was resolved by a more complete PR that ported all the Python files. As such, this is stale. However, you can still contribute by choosing one of the many other issues in our repository and implementing new algorithms/fixing bugs.

@arnavb arnavb added the stale For PRs which are significantly out of date or have been inactive label Mar 31, 2019
@yedhink
Copy link
Contributor Author

yedhink commented Apr 1, 2019

@arnavb I understand that currently this PR will be seen as redundant for fixing #4002 . But as a long term beneficial idea, since Python 2.7 will not be maintained past 2020, can you merge this as part of porting the python2 code to python3 rather than considering this as a stale fix of #4002?

@arnavb
Copy link
Member

arnavb commented Apr 1, 2019

@yedhink I think the previous PR already ported the code to Python 3 as well. Also, there are various merge conflicts to be resolved. If you have any other new changes, feel free to implement them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale For PRs which are significantly out of date or have been inactive

Projects

None yet

Development

Successfully merging this pull request may close these issues.

25 Python files use Python 2 or have Syntax Errors

2 participants