fix #4002 : ported python2 strassen to python3 and added test case#4012
Open
yedhink wants to merge 1 commit intoOpenGenus:masterfrom
Open
fix #4002 : ported python2 strassen to python3 and added test case#4012yedhink wants to merge 1 commit intoOpenGenus:masterfrom
yedhink wants to merge 1 commit intoOpenGenus:masterfrom
Conversation
Member
|
@yedhink This issue was resolved by a more complete PR that ported all the Python files. As such, this is stale. However, you can still contribute by choosing one of the many other issues in our repository and implementing new algorithms/fixing bugs. |
Contributor
Author
Member
|
@yedhink I think the previous PR already ported the code to Python 3 as well. Also, there are various merge conflicts to be resolved. If you have any other new changes, feel free to implement them! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue:
fix #4002
Changes:
removed previous python2 implementation of strassens multiplication and added the python3 code for the same. Also added a test case of a 4x4 matrix for testing the code.
Running Test Case
python3 strassen.py < test_case_4x4_matrix