Updated Implementation of Fibonacci in C++#4115
Open
adevasia wants to merge 4 commits intoOpenGenus:masterfrom
Open
Updated Implementation of Fibonacci in C++#4115adevasia wants to merge 4 commits intoOpenGenus:masterfrom
adevasia wants to merge 4 commits intoOpenGenus:masterfrom
Conversation
This is Fibonacci implemented in C++
nisarg1499
reviewed
Aug 13, 2019
|
|
||
| int get_fib(int num) | ||
| { | ||
| using namespace std; |
Contributor
There was a problem hiding this comment.
Why to keep namespace in individual functions?
Instead I would suggest you to keep it global.
nisarg1499
approved these changes
Aug 13, 2019
ellial
approved these changes
Dec 27, 2019
ellial
left a comment
ellial
left a comment
There was a problem hiding this comment.
The code looks okay. However I don't understand why you choose numbers below 46.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Added a upper limit check
Put namespace into the function
Renamed functions and variables to useful names
Changed array to vector
Made changes to documentation to follow the Style Guide