Added comments maximum and minimum of an array using minimum comparisons(tournament method) #5622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamrajiv
suggested changes
Jun 15, 2020
| #include <cstdlib> | ||
| #include <iostream> | ||
| #include <vector> | ||
|
|
There was a problem hiding this comment.
@mehakmalhotra1 Please remove unwanted line breaks
Contributor
Author
There was a problem hiding this comment.
Please review it
…omparisons_(Tournament Method).cpp
iamrajiv
suggested changes
Jun 16, 2020
|
|
||
| int mid = (beg + end) / 2; //If there are more than 2 elements | ||
| //If there are more than 2 elements | ||
| int mid = (beg + end) / 2; |
There was a problem hiding this comment.
@mehakmalhotra1 it is the wrong way to find mid element this may cause an overflow. Use mid = beg + (end - beg) / 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue:
Changes:
Added comments