Skip to content

Creating expandable buttons#58

Merged
AdiChat merged 7 commits into
OpenGenus:masterfrom
deeheem:expandable_feature
Mar 2, 2018
Merged

Creating expandable buttons#58
AdiChat merged 7 commits into
OpenGenus:masterfrom
deeheem:expandable_feature

Conversation

@deeheem
Copy link
Copy Markdown
Contributor

@deeheem deeheem commented Feb 23, 2018

Fixes issue:

#47

Changes:

When a user searches for a keyword, instead of displaying all languages for all search results at once, they have been converted into clickable buttons as shown in #47.

@AdiChat
Copy link
Copy Markdown
Member

AdiChat commented Feb 28, 2018

Nice addition 👍

Some of the result cards must be expanded by default. This is because as the search improves, few results will appear for a particular search term and in this setting, having few results like three results may look odd.
So, it will be nice to have the top three cards, that is the top card in each column, expanded by default.

Kindly look into this. 👍

@deeheem
Copy link
Copy Markdown
Contributor Author

deeheem commented Feb 28, 2018

@AdiChat, I have made the changes as suggested by you. Now, this is what comes up initially when the search results are displayed:

image

Kindly review the same and suggest changes if any.

@AdiChat
Copy link
Copy Markdown
Member

AdiChat commented Mar 2, 2018

Looks great 😍

Hope you are enjoying your journey 🚆 with OpenGenus

@AdiChat AdiChat merged commit 211952b into OpenGenus:master Mar 2, 2018
@deeheem deeheem deleted the expandable_feature branch March 2, 2018 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants