Fix log viewer worker lifecycle - #1
Merged
Merged
Conversation
|
👀 Human Input Needed → Pair Review Briefing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LogFileLoaderto the thread lifecycle declared by the log-viewer architectureQThread.finishedand reject stale signals by worker identityRoot cause
LogFileLoaderinheritedQThreadbut overrodestart()to launch an unparentedQProcess. Switching logs called a zero-timeout wait and then replaced the loader, which destroyed the child process while it was still running. The race is especially visible during Windows process startup.The loader now performs bounded tail loading in a real interruptible
QThread. Superseded workers remain owned until completion, cannot update a newer selection, and are joined when the viewer closes.Verification
py_compilepassedgit diff --checkpassed